search

amzn / style-dictionary

A build system for creating cross-platform styles.
https://styledictionary.com
Apache License 2.0
3.84k stars 535 forks source link

Possibly wrong type in Config #1280

Closed lukasoppermann closed 1 month ago

lukasoppermann commented 1 month ago

Hey,

shouldn't the Config object accept string[] in the parser? → https://github.com/amzn/style-dictionary/blob/7afcffd56b51f3fb58d0a1051b025ac730924a03/types/Config.ts#L113

export interface Config {
  log?: LogConfig;
  source?: string[];
  include?: string[];
  tokens?: DesignTokens;
  hooks?: Hooks;
  expand?: ExpandConfig;
  platforms?: Record<string, PlatformConfig>;
→ parsers?: Parser[]; <-
  preprocessors?: string[];
  usesDtcg?: boolean;
}
jorenbroekema commented 1 month ago

Yes :D PR welcome