search

amzn / style-dictionary

A build system for creating cross-platform styles.
https://styledictionary.com
Apache License 2.0
3.88k stars 543 forks source link

Remove examples folder from published package #914

Open brettimus opened 1 year ago

brettimus commented 1 year ago

Currently, when you npm i style-dictionary, you end up with all the examples in the examples folder. This is roughly 19mb, which is quite significant!

% mkdir style-dictionary-examples-test && cd style-dictionary-examples-test
% npm i style-dictionary
% du -h node_modules/style-dictionary/examples
...
 19M    node_modules/style-dictionary/examples

Adding examples to the .npmignore would solve this issue.

dbanksdesign commented 1 year ago

Thanks for the feedback! We currently use the examples folder if you use style-dictionary init [simple|complete], but that was before "create" packages became a thing so it would be good to move to a "create-style-dictionary" package and remove the "examples" from the npm artifacts.

adidde1073 commented 1 year ago

Is there any way we can revisit this? Currently, we're having a security issue because some of the dependencies (FasterXML/jackson-core) need to be updated