search

analogdevicesinc / TMC-API

TRINAMIC's IC API
MIT License
188 stars 83 forks source link

#define TMC5272_MSLUT_START_OFFSET_SIN90_FIELD wrongly defines the field value as unsigned. #56

Open chrislro2019 opened 5 months ago

chrislro2019 commented 5 months ago

https://github.com/analogdevicesinc/TMC-API/blob/f276b3e94894494009a1c44e3eb21512ad0ab320/tmc/ic/TMC5272/TMC5272_HW_Abstraction.h#L295C1-L295C196

// is
#define TMC5272_MSLUT_START_OFFSET_SIN90_FIELD                ((RegisterField) { TMC5272_MSLUT_START_OFFSET_SIN90_MASK,  TMC5272_MSLUT_START_OFFSET_SIN90_SHIFT,  TMC5272_MSLUT_SEL_START, false })
// should be signed according to datasheet ("Signed offset for CUR_B ±127 microsteps")
#define TMC5272_MSLUT_START_OFFSET_SIN90_FIELD                ((RegisterField) { TMC5272_MSLUT_START_OFFSET_SIN90_MASK,  TMC5272_MSLUT_START_OFFSET_SIN90_SHIFT,  TMC5272_MSLUT_SEL_START, true })