analogjs / analog

The fullstack meta-framework for Angular. Powered by Vite and Nitro
https://analogjs.org
MIT License
2.57k stars 245 forks source link

[FEAT]: configure tsconfig.app.json location #129

Closed marcjulian closed 1 year ago

marcjulian commented 1 year ago

Which scope/s are relevant/related to the feature request?

astro-angular

Information

I am using nx workspace together with @nxtensions/astro to generate an astro application into apps directory.

When using astro with @analogjs/astro-angular it requires a tsconfig.app.json at the root location. As this tsconfig is only required by astro-angular, it would be nice to change the location to the apps directory e.g. apps/website/tsconfig.app.ts.

@analogjs/vite-plugin-angular can be configured with PluginOptions which already allows to specify the tsconfig file.

Cloud @analogjs/astro-angular provide the PluginOptions passing them to @analogjs/vite-plugin-angular for configuration?

Describe any alternatives/workarounds you're currently using

Currently the tsconfig.app.json is required in the root directory.

One option is to keep the configuration in the astro project by creating the tsconfig.app.json in root pointing to a tsconfig.app.json in the astro project.

{
  "extends": "./apps/website/tsconfig.app.json"
}

I would be willing to submit a PR to fix this issue

brandonroberts commented 1 year ago

Yep, that would be good to have. I just hadn't made the options available to the Astro integration yet.