anathema / anathema_legacy

Anathema is an exhaustive suite for all aspects of Exalted series management. This repository hold the code to support Exalted 1, Exalted 2 and Exalted 2.5.
http://anathema.github.com
69 stars 70 forks source link

Exported Character Sheets in 5.1.2 Cannot Be Imported by 5.1.2 #344

Open Tenacious-Techhunter opened 11 years ago

Tenacious-Techhunter commented 11 years ago

I was planning on having all my Exalted players send me exported Anathema sheets, but they don't Import, even by their own copies which MADE them. Fix it, please. :) Also, on a slightly related note, please don't require that the Exported file stay zipped... if someone's browser or system unzips zipped files by default, just let them Import the unzipped version too. But neither version currently Imports, so still, fix it, please. :)

UrsKR commented 11 years ago

I am surprised to hear that. I would love to have a look at the issue - would you mind sending me one of the zips that you can't import? You can reach me via my profile's email address.

As for your second request, that won't happen soon - we have just changed character persistence to a multi-file format, and while we have made a note to make ex- and importing easier, it is not our focus right now.

(@curttasker, you may be interested in this discussion, as you brought up the issue earlier.)

curttasker commented 11 years ago

@UrsKR I finally had some time to take a look at the new file format, and I'll post in detail once I've collected my thoughts.

To boil it down:

I'm very much in favor of making it easier to share all custom Anathema data between clients (characters, custom charms, custom spells, and custom equipment). In fact, I probably feel more strongly about file formats and import/export than the rest of the team. I have eventual plans to make it almost effortless to share your custom data with your storyteller, but I'm not sure if its something that should be worked on before the 3E release, or after. That said, it may require some forethought before we lock in the 3E file formats.

Since we'd all prefer not to have our file formats change over time, I'd like to have some serious discussion and thought put into it before we declare the new multi-file character format complete.

Tenacious-Techhunter commented 11 years ago

I don’t know where the issue of “resource forks” lie in the grand scheme of file system design, but that’s the approach I’d take, if it was still workable in the modern age. Then again, I may just be showing my Classic Mac OS roots here...

Regardless, for some background info on Resource forks, and how Operating Systems usually solve this sort of problem, check out the Wikipedia page here: http://en.wikipedia.org/wiki/Resource_fork

Tenacious-Techhunter commented 11 years ago

Well, in spite of the insistence of my players, I appear to not have the problem currently, at least with my own files from my own Anathema copy. I’ll try downloading their files again, to make sure import is still busted. And I’ll try deleting Anathema, and importing from a freshly installed version... maybe the problem is temporary?

Tenacious-Techhunter commented 11 years ago

O.K., the Exported Character Sheet files from other players still don’t work with the copy of Anathema that imported its own character exports. Exported characters from that copy of Anathema still import, with an important caveat that should be looked into more closely... When you import a file, and the import is successful, the list of characters in the character pane does not refresh until after Anathema is quit and restarted. This makes it look like file imports are not successful, even when they are. Successfully Imported files will still display in the Repository Browser, though. You need to make sure the list of characters in the character pane refreshes. Regardless, the zip files from my players still don’t import, not even making it onto the Repository Browser list. I’ll get you permission to download the files from my player.

UrsKR commented 11 years ago

Yes, I know about that later issue, will fix it for 3E.

If your players don't want to share their characters, any broken file will do, even if they created it just for testing purposes.

Tenacious-Techhunter commented 11 years ago

You can find a character sheet here: http://wikisend.com/download/370706/IselsiRinsi.zip

For some reason it just doesn’t import.

UrsKR commented 11 years ago

The file appears to be empty - or broken. I can clearly see the error you spoke about, but it's not terribly helpful. I assume that Anathema fails to export it for some reason I can't yet discern. Would you mind uploading the raw character file as you find it in Anathema's data repository?

Depending on the complexity of the issue, I'll gladly correct the behavior for a 2.5E version.

For reference, here's the exception:

java.util.zip.ZipException: error in opening zip file
    at java.util.zip.ZipFile.open(Native Method) ~[na:1.7.0_21]
    at java.util.zip.ZipFile.<init>(ZipFile.java:214) ~[na:1.7.0_21]
    at java.util.zip.ZipFile.<init>(ZipFile.java:144) ~[na:1.7.0_21]
    at java.util.zip.ZipFile.<init>(ZipFile.java:158) ~[na:1.7.0_21]
    at net.sf.anathema.framework.repository.tree.RepositoryItemImportPresenter$1.execute(RepositoryItemImportPresenter.java:57) ~[Platform_Swing/:na]
Tenacious-Techhunter commented 11 years ago

Tell me how to get to it, I’ll see if the user my example comes from can manage it if I talk them through it.

UrsKR commented 11 years ago

Easiest way would be to

  1. Launch Anathema
  2. Go to File/Preferences
  3. Go to the repository tab
  4. Click "Open this directory"
  5. Go to the ExaltedCharacter folder
  6. Pick your file and send it over
Tenacious-Techhunter commented 11 years ago

I tried getting my players to give me their export files... only one out of three managed to give me the compressed version; I got .ecg files from the other two. Not exactly helpful for your testing, but important to consider from a usability point of view.

redaikidoka commented 9 years ago

is there a way you can put in an .ecg updater for the next update so we can still get player files? :dancer:

UrsKR commented 9 years ago

Sorry, @redaikidoka, could you give me some more details? I remember there could be an issue with the ZIP import and export, but I can't put your request into context.

redaikidoka commented 9 years ago

I mean is there any way to build in importing .ecg files in the newest version, rather than .zips?

UrsKR commented 9 years ago

Sure is. Just place the .ecg into the ExaltedCharacter directory in your repository folder. Easiest way to get there is to open Anathema, go "File=>Preferences", open the Repository tab and click "Open this directory". Then just drag the .ecgs onto the ExaltedCharacter folder.

Does this help you?

UPDATE: Sorry, I misread you. I thought you were asking for any way to do it, not for any way to build it into the program. There is a way to build it in as well, by extending the repository manager's import/export code. We won't change that for 5.1.2 though, and the storage format has changed so significantly for 3E that we have to re-think the approach there.

Tenacious-Techhunter commented 9 years ago

The point is to be able to mail a character sheet to someone, and have them be able to open it easily. You should be able to browse to the file's current location and open it that way, if at all possible, for convenience on the receiving end.

Glad to see this issue isn't being forgotten.

Ryan Pettigrew

On Mar 14, 2015, at 4:05 PM, Urs Reupke notifications@github.com wrote:

Sure is. Just place the .ecg into the ExaltedCharacter directory in your repository folder. Easiest way to get there is to open Anathema, go "File=>Preferences", open the Repository tab and click "Open this directory". Then just drag the .ecgs onto the ExaltedCharacter folder.

Does this help you?

— Reply to this email directly or view it on GitHub.

redaikidoka commented 9 years ago

oh! Thanks!