andersonwinkler / PALM

PALM: Permutation Analysis of Linear Models
70 stars 28 forks source link

Replace empty cells with zero #40

Closed smazurchuk closed 2 years ago

smazurchuk commented 2 years ago

This function currently fails if fprintf receives an empty cell. This is an edit I've made in my copy and it seems to work fine. If you would like an example file for when palm fails, I can upload those so that you can see the error.

Of note, this does not appear to be a problem for palm116 in octave as the same command runs for palm116 and octave that fails for palm119 and matlab 2020

andersonwinkler commented 2 years ago

Hi Stephen,

Thanks for this. The GIFTI functionality comes from the GIFTI Toolbox (https://github.com/gllmflndn/gifti), created and maintained by Guillaume Flandin @gllmflndn. The best would be for you to make the PR there, and once Guillaume has reviewed and merged, I can update the copy here. Otherwise we'd end up with two forks maintained separately...

Thanks again!

All the best,

Anderson

smazurchuk commented 2 years ago

Okay great! Thanks for pointing me to that. I opened a pull request there :)

Stephen