Added 2 capabilities to the Python wrapper:

andre-martins / AD3

Alternating Directions Dual Decomposition

GNU Lesser General Public License v3.0

68 stars 38 forks source link

Added 2 capabilities to the Python wrapper: #19

Closed jlmeunier closed 6 years ago

jlmeunier commented 7 years ago

Hi, I'm proposing an extension to the AD3 Python wrapper, to exploit the AD3 logic constraint functions. Also, AD3 supports nodes having a variable number of states. This is another extension to the wrapper. Those 2 features have been extensively tested and used in an extension to pystruct, which I proposed to Andreas. All this work is reported in a CAp 2017 paper ( arXiv:1708.07644) and ICDAR OST paper to come. Thanks JL

Extensions:

handling logic constraints by binarizing the graph
handling multiple types of nodes (the node type defines the list of possible states of the node)
handling jointly multi-type and constraints in inferences
Added the corresponding unit tests Benefits from other additions below made by vlda@vene.ro

vene commented 7 years ago

Hi @jlmeunier, thanks a lot for this! Sorry for not merging your older PR when I made the recent release, I wanted to have it out quickly before my paper presentation. I will get on reviewing this soon, I am travelling over the next couple of days but I should be able to look next week.

For reference, I will probably be taking over the "release engineering" part of AD3 since I will be working very closely with it in the future, but of course @andre-martins remains the boss.

vene commented 7 years ago

Just checking: this supersedes #16 which we can close now, right?

jlmeunier commented 7 years ago

Hi Vlad, Thanks for your answer! Yes, the latest PR supersedes #16, which I closed. (Didn't know about closing PR before your post...) JL

andre-martins commented 7 years ago

Thanks a lot for contributing @jlmeunier !

@vene re the Xerox copyright: yes, it doesn't seem to make much sense to have it here. I guess this will disappear when the README.md file gets merged with the official README?

jlmeunier commented 7 years ago

Hi Vene and André, Thanks for having looked at this PR! I will do my duty ASAP, but I'm too busy those days. So, expect some action from me in the coming weeks, or by end of year at the latest.

jlmeunier commented 6 years ago

Hi Vene, I did what was needed (PEP8 compliance, example of use of the Python wrapper, explanation of its API) Have a look and let me know. Thanks (and wishing you an happy Xmas!) JL

jlmeunier commented 6 years ago

(And yes, no need to propagate the Xerox copyright.)

vene commented 6 years ago

Hi, thanks a lot for the update! I promise to take a look soon.

jlmeunier commented 6 years ago

Hi Vene sorry, while testing with Python3, a bug that I introduced when formatting the code for PEP8 showed up... So now, things are fine.

vene commented 6 years ago

Merged via #20, thanks @jlmeunier!