andreafrancia / trash-cli

Command line interface to the freedesktop.org trashcan.
GNU General Public License v2.0
3.58k stars 179 forks source link

trash-empty sometimes at random spools/spins up all my parked disks #252

Open Puuma opened 1 year ago

Puuma commented 1 year ago

My system has a number cold storage disks that are spun down most of the time. And spinning them up and down will decrease their potential lifetime, so I would like to avoid doing that pointlessly.

Sometimes when i run trash-empty it spins up the parked disks. I couldn't figure out what was going on. Was it looking at every mount point for trash to empty. And why was it only sometimes spinning the disks up.

Maybe it would be useful to be able to tell it that "there is never trash to empty on these filesystems/mountpoints".

andreafrancia commented 1 year ago

Please fill a proper bug issue template (see below). Give more information as possible. I don't know nothing about cold storage. Please be sure of using the latest version of trash-cli before fill the bug report.

**Describe the bug**
A clear and concise description of what the bug is.

**trash-cli version**
Output of: trash-put --version

**Operating system:**
 - OS: [e.g. Debian, Ubuntu, Fedora, macOs, Cygwin]

**To Reproduce**
Copy and paste the commands (and their output) to execute in order to reproduce 
the behavior:

$ touch foo
$ trash-put foo
$ ls foo
gls: cannot access 'foo': No such file or directory
$ trash-list
2020-12-13 18:36:21 /Users/andrea/trash-cli/foo

**Expected behavior**
A clear and concise description of what you expected to happen.
Puuma commented 1 year ago

trash-put 0.17.1.1 Debian

There are physical drives on my computer machine with rarely accessed files on them. Physical drives are mounted during boot time, after which they are spun down by the drive firmware based on time-since-last-access. They are blacklisted from being accessed by any sort of regular system maintenance tasks, so that only thing causing them to spool up should be an user requesting to read or write to said drives. All this is done to increase the drive MTBF.

Steps to reproduce: It's random. No way to reliably reproduce. Happens: sometimes Step1: trash-empty Step2: observe with my ears drives spooling up, when I know for a fact that there is no trash to empty on that drive

It may or may not be a bug. If it is supposed to exhaustively check every mount point for trash to empty, then it's working as intended. Due to the lack of documentation, and my inability to read code that is not C-like syntax, I don't know what it's supposed to do.

andreafrancia commented 1 year ago

The version you are using is from 5 years ago.

Please install the latest version of trash-cli:

$ pip install pip install git+https://github.com/andreafrancia/trash-cli

The send me the output of:

$ trash-list --debug-volumes

Please redact any personal or sensitive information. And, please indicate which mount point you don't want to be cleared by trash-empty.

Unfortunately trash-empty can not know if a volume does not contains any trash before reading it's trash folders.