search

andreif / uwsgi-tools

curl and proxy for remote uwsgi app server
BSD 3-Clause "New" or "Revised" License
43 stars 11 forks source link

Easier to read pack uwsgi vars #8

Closed tomdottom closed 6 years ago

tomdottom commented 6 years ago

NOTE: builds on work in #7

This is some work I did whilst trying to debug another issue. It doesn't change the functionality. But now we are able to reference uwsgi definitions documented at http://uwsgi-docs.readthedocs.io/en/latest/Protocol.html

From commit 5879abe0d2419d623682f630de3e12cc97f94779:

Updates pack_uwsgi_vars

Old packing of uwsgi vars seemed a little bit like magic and was hard to understand
at least for mere mortals like myself.

Created a pair of C Structures using definitions on uwsgi site and a helper function
to convert to bytes.
andreif commented 6 years ago

Thanks! Could you please fix linting errors?

andreif commented 6 years ago

Also, please, rebase on master. GitHub stopped doing it automatically it seems.

tomdottom commented 6 years ago

Rebased and ready to merge.

tomdottom commented 6 years ago

:thinking: I'm not sure why the coverage test stalled

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at ?% when pulling caba37789ca2dfd8c1b116f33f03aa61559d4a83 on tomdottom:easier-to-read-pack-uwsgi-vars into b79b267a75210b8845745fd88498733aa613c745 on andreif:master.

tomdottom commented 6 years ago

Changes implemented

andreif commented 6 years ago

Awesome, thanks!