andrejilderda / joplin-macos-native-theme

Native looking macOS theme for note taking app Joplin
MIT License
289 stars 14 forks source link

Use white backgrounds for mermaid diagrams #55

Closed ianchanning closed 2 years ago

ianchanning commented 2 years ago

Hi there,

I'm using Joplin on Linux and I was trying some mermaid diagrams yesterday. Your theme uses a grey background which conflict with the diagrams making the grey arrows hard to see. Here's two screenshots one with your theme and one with the base 'Light' theme.

See this comment from the mermaid diagrams docs above:

Note that Mermaid graphs are always rendered on a white background regardless of the current theme. This is because they can contain various colours that may not be compatible with the current theme.

Mac OS theme Screenshot from 2022-02-14 16-15-43

Default Light theme Screenshot from 2022-02-14 16-16-40

andrejilderda commented 2 years ago

Hi @ianchanning , I've just pushed an update that should fix your issue. It will be picked up by the Joplin bot in around 30 mins.. Let me know if it works for you!

ianchanning commented 2 years ago

Yes, awesome it works! Thank you :) Screenshot from 2022-02-25 11-40-24