search

andresz1 / size-limit-action

Compare the real cost to run your JS app or lib to keep good performance in every pull request
ISC License
453 stars 84 forks source link

Dcwither/option update #20

Closed dcwither closed 4 years ago

dcwither commented 4 years ago

Addresses comments from #18. Currently untested, so not in a good state to merge.

dcwither commented 4 years ago

I've managed to fix a few bugs, leading to a passing run, though unfortunately I've been unable to test this thoroughly within this repo.

The check fails here due to permissions, and it simply doesn't run when I attempt to merge to my master regardless of changing the on configuration to any pull request. You might be able to rerun this to test it out, though I encourage you to pull it down and take a look.

I'll also pursue testing this branch running on another project when I can find the time.

andresz1 commented 4 years ago

Hi @dcwither! looks nice! 🎉 thank you so much! I think that you can test it creating a PR to your own forked repo, have you tried doing that ? Sorry for the late reply 😞 I've been really busy this past two weeks I'll try this out ASAP.

Thank you again and let me know if you can test it that way 😉

dcwither commented 4 years ago

I think that you can test it creating a PR to your own forked repo, have you tried doing that?

I did try that, I'm not sure why it didn't run at all. Here's the links to the attempts (though they're closed so they're not showing the checks) https://github.com/chanzuckerberg/size-limit-action/pull/3 https://github.com/chanzuckerberg/size-limit-action/pull/2

Sorry for the late reply 😞 I've been really busy this past two weeks I'll try this out ASAP.

No worries, I've been busy as well and haven't had the opportunity to test this branch with another project that would hopefully confirm things. Thanks for taking a look when you can 😄

andresz1 commented 4 years ago

Hi @dcwither! I thought that maybe making you collaborator will enable you to test it out but now I think that just forking the repo yourself and not from an orga would work. Can you try it and let me know if it works (see forked repo PR)