Closed Klemensas closed 3 years ago
Hi @Klemensas!
Thank you so much for opening the PR ❤️ . The changes look good but I have a few questions:
.npmrc
file?. Something like this:
//registry.npmjs.org/:_authToken=${NPM_TOKEN}
base
and head
, base
must be generated performing a checkout
to the ref. Are you doing this ? or you want to do something different?Thank you again. Happy to help you!
Could this install problem be solved using a .npmrc file?. Something like this:
Supporting npmrc would potentially solve the majority of such cases. But my situation might be a bit of an edge case, I'm pulling dependencies directly from a private git repo. Doing that over ssh and adding a key beforehand. At least I'm not aware of a way to have it work via npmrc. It could be solved by adding support here for pulling via ssh. But I figured it's best to just support providing the files instead of trying to support all edge cases since it's likely there'll be more.
How do you generate base and head, base must be generated performing a checkout to the ref. Are you doing this ? or you want to do something different?
Oh, sorry, I omitted the checkout part in my example above. Edited with that part. Basically I'm doing the setup in my action flow with the needed credentials.
Hi @Klemensas, thank you for the clarification! I think that would be nice to add a brief explanation of the two new optional action inputs to the README.md
. What do you think?
Regards
For sure. Added a note, tried following the current format you have
I have a case where I need additional auth to install dependencies and my size-limit configuration is not in the root path.
So to support such a case I've added additional inputs for
base_size_path
andhead_size_path
. These paths should lead to an already generated size limit report. Providing a path tries to load the file directly and skips the install, build, exec steps.To use this you should do your setup in the action and just pass the paths, my usage looks something like this: