search

andresz1 / size-limit-action

Compare the real cost to run your JS app or lib to keep good performance in every pull request
ISC License
451 stars 84 forks source link

Crashing out when run as action but not manually. #54

Closed The-Code-Monkey closed 3 years ago

The-Code-Monkey commented 3 years ago

https://github.com/AW-Web-Design/styled-system/runs/2619264107

here is a link to the github run that keeps failing at the bottom it says.

Error parsing size-limit output. The output should be a json.
Error: Unexpected end of JSON input

its also asking me to install packages when they are already installed, the config im using has come from tsdx which i have not modified.

gtkatakura commented 3 years ago

It is a problem related to your first install of the action because you don't have size-limit for your target branch and when it tries to run it to compare the results, it crashes. Maybe we check for the size-limit into package.json into the target branch and just show the results without comparing into this case?

andresz1 commented 3 years ago

Yes! this happens only on first install. If you merge the PR it should work as expected! feel free to reopen the issue if not