search

andrewdavey / knapsack

Project moved to https://github.com/andrewdavey/cassette
MIT License
24 stars 3 forks source link

Ignore hidden and empty folders #6

Closed jochenjonc closed 13 years ago

jochenjonc commented 13 years ago

When Knapsack creates the modules and stores them in the isolated storage, more files are created then there modules.

In my case I have files for my .svn folders that are under scripts and styles folder, these are hidden folders and I think they should be ignored all the way. I have also a styles_images_da39a3ee5e6b4b0d3255bfef95601890afd80709 files, this is a folder under the styles folder, that contains the images but no css-files.

These modules can also be found in the manisfest xml-files.

So knapsack should ignore hidden folders and should not create modules for empty folders.

andrewdavey commented 13 years ago

Yes, we need to prevent Knapsack from picking up hidden directories. Ignoring "empty" directories also makes sense and should be an easy fix. Thanks for the continued beta-testing and excellent feedback! :)

andrewdavey commented 13 years ago

I've pushed changes to master. It should now ignore hidden and "empty" directories.

jochenjonc commented 13 years ago

Wonderful