Closed jeremymturner closed 2 years ago
@jeremymturner thanks for this! I do think it'd be better just to have a single log_level option instead, however. Would you mind doing it that way? Also note to run the unit tests, run from the root of the repo: bash tests/run_tests.sh
(apologies I never documented this properly)
Thank you for writing this util! I’ll refactor with log_level. I’m also thinking stdout_format (eg json or text) would be good.
On Aug 9, 2022, at 19:06, Andy Fraley @.***> wrote:
@jeremymturner https://github.com/jeremymturner thanks for this! I do think it'd be better just to have a single log_level option instead, however. Would you mind doing it that way? Also note to run the unit tests, run from the root of the repo: bash tests/run_tests.sh (apologies I never documented this properly)
— Reply to this email directly, view it on GitHub https://github.com/andrewfraley/arris_cable_modem_stats/pull/47#issuecomment-1210038887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARJXCIX42LSPPNP5KJXVALVYL6CZANCNFSM56BRFPKQ. You are receiving this because you were mentioned.
This is looking good, you'll just need to add the new variable to the Dockerfile and here so that the tests will pass.
also we'll want to remove the --debug arg and the documentation surrounding it, and then add documentation to the README for the new log_level functionality
Enable
destination = stdout
in the config file, to allow json data to be sent to standard outEnable
arris_stats_info = True
in the config file, to allow information messages to be enabled or disabledThis could be implemented as a log_level (DEBUG/INFO/ERROR) instead of True/False.