search

andrewgioia / keyrune

Magic: the Gathering set symbol pictographic font
Other
456 stars 45 forks source link

[Question] How to handle icons that use x infront of the set code? #245

Open icobg123 opened 1 month ago

icobg123 commented 1 month ago

Hi,

I'm experiencing an issue with some of sets that use x infront of the set code. The set code for Renaissance is ren in MTGJSON, but in order to display the icon correctly, I need to use the class ss-xren instead.

Is there a recommended way to resolve this discrepancy, or would it be possible to update the library to support the ren set code directly for the Renaissance icon?

Thanks in advance for your help!

andrewgioia commented 1 month ago

Sorry for the delayed response @icobg123. We use x as a class prefix whenever the set code is not an official one recognized by WotC. The issue is if it’s not official there’s nothing stopping WotC from creating a future set with that set code and causing a problem for us.

I didn’t realize MTGJson used ren for it, I’ll take anlook today and see if it is in fact official and update the aliases.

andrewgioia commented 1 month ago

Wizards doesn't list Renaissance *or Rinascimento in Gatherer, but since MTGJSON and Scryfall both went with REN and RIN I think we can do the same.