search

andrewgross / pyrelic

New Relic Python API
MIT License
21 stars 11 forks source link

Python3 support #21

Closed delfick closed 9 years ago

delfick commented 9 years ago

I've made the vendored packages install_requires and added some decode('utf-8') and fixed print statements in pre-commit.

andrewgross commented 9 years ago

Thanks for sending this over, I will review it shortly!

delfick commented 9 years ago

cool cool :)

Any update on this ?

andrewgross commented 9 years ago

Sorry totally forgot. Will tackle it tomorrow. On May 12, 2015 7:46 PM, "Stephen Moore" notifications@github.com wrote:

cool cool :)

Any update on this ?

— Reply to this email directly or view it on GitHub https://github.com/andrewgross/pyrelic/pull/21#issuecomment-101461433.

delfick commented 9 years ago

excellent :)

andrewgross commented 9 years ago

Why do we want to move away from vendored packages? Is this the only way to get python3 working properly?

delfick commented 9 years ago

I couldn't work out where you were getting elementtree code from and requests is a very stable library.

On Thu, 14 May 2015 04:48 Andrew Gross notifications@github.com wrote:

Why do we want to move away from vendored packages? Is this the only way to get python3 working properly?

— Reply to this email directly or view it on GitHub https://github.com/andrewgross/pyrelic/pull/21#issuecomment-101773952.

andrewgross commented 9 years ago

The main reason I vendored the requests code is so that it wouldnt conflict with any version the user might be using already, on the fence about it.

delfick commented 9 years ago

Fair enough. Feel free to vendor it again.

On Thu, 14 May 2015 07:03 Andrew Gross notifications@github.com wrote:

The main reason I vendored the requests code is so that it wouldnt conflict with any version the user might be using already, on the fence about it.

— Reply to this email directly or view it on GitHub https://github.com/andrewgross/pyrelic/pull/21#issuecomment-101816084.

delfick commented 9 years ago

Do you want me to repush with requests vendored? (this pull request is blocking me releasing the next version of my application (http://bespin.readthedocs.org/))

andrewgross commented 9 years ago

Yes lets try that. I was messing around with trying to unvendor elementtree but lock a specific version, which seems hopeless.

andrewgross commented 9 years ago

Sorry for being so behind on this, very busy moving the last couple of weeks. I am going to merge this in to master and bump the major version number for now.

andrewgross commented 9 years ago

Version 0.8.0 released with python3 support, let me know how it goes @delfick

delfick commented 9 years ago

Yay! Thankyou so much :)

I hope your move went well.

Got a busy day today, but I should get around to making a pull request vendoring requests later on if you still want.

On Thu, 21 May 2015 at 05:46 Andrew Gross notifications@github.com wrote:

Version 0.8.0 released with python3 support, let me know how it goes @delfick https://github.com/delfick

— Reply to this email directly or view it on GitHub https://github.com/andrewgross/pyrelic/pull/21#issuecomment-104011382.