search

andrewhooker / PopED

Population Experimental Design (PopED) in R
https://andrewhooker.github.io/PopED/
GNU Lesser General Public License v3.0
33 stars 21 forks source link

Minor bugs. #44

Closed martin-gmx closed 4 years ago

martin-gmx commented 4 years ago

Without notfixed in shrinkage.R problems inverting matrix. Without setting temp_1 in mf3.R crash with notfixed_bpop == 0.

andrewhooker commented 4 years ago

Just thought of a situation where your solution won't work for shrinkage. If we have an omega that is nonzero but fixed, we will certainly still have shrinkage. Your solution to the fixing problem ignores that parameter. I think we can only ignore if the OMEGA is zero. Otherwise we need to account for it.

martin-gmx commented 4 years ago

You're right. Good that you spotted this. :-)