andrewhooker / PopED

Population Experimental Design (PopED) in R
https://andrewhooker.github.io/PopED/
GNU Lesser General Public License v3.0
33 stars 21 forks source link

PopED + babelmixr2 for windows #79

Open mattfidler opened 1 month ago

mattfidler commented 1 month ago

Hi @andrewhooker

This allows windows based PopED models from babelmixr2 to be run in parallel without modifying any user code. This mean the same user code works on windows and linux/mac

This requires the following pull request for babelmixr2:

https://github.com/nlmixr2/babelmixr2/pull/141

mattfidler commented 1 month ago

In general it saves the babelmixr2 environment inside of the poped.db setup from babelmixr2. With the windows parallelization, this environment is sent to every R process node to load the DLLs. This will allow everything to be contained inside of babelmixr2 in case things like symbolic sensitivity gradient models are added to speed up PopED and rxode2. Right now there are 2 models/dlls generated for each poped database.

mattfidler commented 1 month ago

Had to add babelmixr2 development stack so these check correctly. After adding this to CRAN you can take out the babelmixr2 stack and can simply use the CRAN version.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 60.97561% with 32 lines in your changes missing coverage. Please review.

Project coverage is 44.68%. Comparing base (1b8c9cc) to head (63f3442).

Files with missing lines Patch % Lines
R/start_parallel.R 0.00% 5 Missing :warning:
R/optimize_n.R 40.00% 3 Missing :warning:
R/blockexp.R 0.00% 2 Missing :warning:
R/ind_estimates.R 0.00% 2 Missing :warning:
R/LEDoptim.R 0.00% 1 Missing :warning:
R/LinMatrixLH.R 50.00% 1 Missing :warning:
R/LinMatrixL_occ.R 0.00% 1 Missing :warning:
R/blockopt.R 0.00% 1 Missing :warning:
R/blockother.R 0.00% 1 Missing :warning:
R/create_ofv.R 0.00% 1 Missing :warning:
... and 14 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #79 +/- ## ========================================== + Coverage 44.52% 44.68% +0.15% ========================================== Files 120 121 +1 Lines 8810 8892 +82 ========================================== + Hits 3923 3973 +50 - Misses 4887 4919 +32 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mattfidler commented 2 weeks ago

As babelmixr2 was released on CRAN development libraries are no longer neeeded.

mattfidler commented 2 weeks ago

The error in oldrel-1 is unrelated to this pull request.