andrewprock / pokerstove

poker evaluation and enumeration software
BSD 3-Clause "New" or "Revised" License
795 stars 348 forks source link

Build gtest along with cmake #77

Closed miker2049 closed 1 year ago

miker2049 commented 3 years ago

Rather than using find_library, point it to subdirectory and build.

as mentioned here: https://github.com/google/googletest/tree/master/googletest#incorporating-into-an-existing-cmake-project

I tried using the #75 pr from @lucasmitrik, but in my rolling arch release, the system gtest was incompatible and got a lot of errors.

This significantly increases build time, but keeps the test dependencies pinned to whatever is in the source files, and I think should increase portability in general.

JonathanLehner commented 2 years ago

great pr