search

andrewrk / sdl-zig-demo

SDL2 hello world in zig
MIT License
116 stars 20 forks source link

Fixed build using Zig 0.7.0 on Gentoo Linux. #8

Closed billsix closed 11 months ago

billsix commented 3 years ago

Regarding build.zig, I found that andrewrk had fixed another project using the changes that I imported.

https://github.com/baverman/sdl-zig-demo/commit/bfc3644b8928d76ed0fee941b9af95e4b7ea1ff7

Per Reddit, from what I gathered, all strings are now null terminated, so the 'c' prefix before a string is unnecessary.

https://www.reddit.com/r/Zig/comments/fq504d/cstring_literals_not_working_zig_05_on_windows_10/

Will try to get zig 0.7.0 build into main gentoo tree.

billsix commented 3 years ago

Closed due to lack of interest

andrewrk commented 11 months ago

Thanks, I fixed it myself just now.

billsix commented 11 months ago

Thank you. I wish to apologize for how I spoke on hackernews about this PR a while back. I had closed the PR after a week, in my head thinking you were just ignoring a simple fix, which was impatient of me. Again, I apologize, it looks to me like you're doing great work, and I hope you have a great day!

andrewrk commented 11 months ago

Didn't even notice, don't worry :slightly_smiling_face: