search

andrewzm / FRK

Fixed Rank Kriging with big data
https://andrewzm.github.io/FRK/
66 stars 20 forks source link

Early warning of r-spatial evolution #6

Open rsbivand opened 2 years ago

rsbivand commented 2 years ago

Because FRK suggests rgeos and rgdal, it is vulnerable to: https://r-spatial.org/r/2022/04/12/evolution.html. Running revdeps on a platform without rgdal, rgeos or maptools (but sp evolution status 2, using sf for coordinate transformation and CRS definition), I see: 00check.log

My Matrix is current R-forge development 1.4-2, because some of the packages I maintain also needed adapting.

andrewzm commented 1 year ago

FRK now passes tests with rgeos and rgdal and that error seen in the CHECK with the Matrix has been sorted. However I'm keeping this issue open as when using sf when finding overlapping polygons on sphere is not giving exactly the same results as rgeos and will need to be investigated further at a later stage (edits in 2022_12_rgdal_dependency/ branch)

rsbivand commented 1 year ago

Is sf branching to s2? Does sf_use_s2(FALSE) help? When the geometries are planar, or s2 use is turned off, GEOS is used (but with a slightly different precision model from rgeos). If the geometries are spherical, and s2 use is on, the s2 library is used instead of GEOS.

andrewzm commented 1 year ago

It definitely has Roger, thank you!

Best, Andrew

On Fri, Dec 23, 2022 at 6:49 AM Roger Bivand @.***> wrote:

Is sf branching to s2? Does sf_use_s2(FALSE) help?

— Reply to this email directly, view it on GitHub https://github.com/andrewzm/FRK/issues/6#issuecomment-1363283108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABEU3NHKHCA4F6E46YR7JTWOSWDHANCNFSM57Z2MDOA . You are receiving this because you commented.Message ID: @.***>

rsbivand commented 1 year ago

@andrewzm rgdal was archived yesterday, so please do move to submit an updated version of FRK as soon as possible. See https://github.com/r-spatial/evolution https://r-spatial.github.io/evolution/ for details.

andrewzm commented 1 year ago

Thank you Roger, will do it now.

On Wed, Oct 18, 2023 at 1:00 AM Roger Bivand @.***> wrote:

@andrewzm https://github.com/andrewzm rgdal was archived yesterday, so please do move to submit an updated version of FRK as soon as possible. See https://github.com/r-spatial/evolution https://r-spatial.github.io/evolution/ for details.

— Reply to this email directly, view it on GitHub https://github.com/andrewzm/FRK/issues/6#issuecomment-1766599182, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABEU3MRGU2J5BJUVIEEPJLX72MPTAVCNFSM57Z2MDOKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCNZWGY2TSOJRHAZA . You are receiving this because you were mentioned.Message ID: @.***>