andsens / homeshick

git dotfiles synchronizer written in bash
MIT License
2.11k stars 145 forks source link

Fix branch name extraction #50

Closed jjlin closed 11 years ago

jjlin commented 11 years ago

Instead of using basename, just remove the "refs/heads/" prefix. With basename, branch names like "foo/bar" become just "bar".

andsens commented 11 years ago

Good catch. I'll merge as soon as I have run the testsuite, unless you already did?

jjlin commented 11 years ago

Nah I didn't run it, but it was my bug from when I switched from --short to using basename instead.

andsens commented 11 years ago

Merging. I have a test ready to check for that bug. Writing tests is getting easier and easier now :-)

jjlin commented 11 years ago

Good to know. I may even try writing one someday. :)