andsens / homeshick

git dotfiles synchronizer written in bash
MIT License
2.11k stars 145 forks source link

Version control "Files outside your home directory"? #66

Closed leoj3n closed 11 years ago

leoj3n commented 11 years ago

Regarding this section:

Wouldn't it make more sense for a links/ directory to be placed under version control?

Personally I'd place links/ under .homesick/repos/webapp/ (or whatever castle name) instead of under .homesick/.

leoj3n commented 11 years ago

Well, I guess the "flat symlinking method" has it under the castle repo.

Edit: Nevermind, I see it references the links/ directory still. Examples are hard to follow.

leoj3n commented 11 years ago

However, I'm not convinced: Isn't the first example counterintuitive? Shouldn't links/ be under version control? I'm a tad turned around.

leoj3n commented 11 years ago

I think the docs could be improved. It's not clear that var-www is a symlink to /var/www.

leoj3n commented 11 years ago

I can confirm this works as expected:

~/.homesick
└── repos
    └── dotfiles
        ├── home
        │   └── .homesick
        │       └── repos
        │           └── dotfiles
        │               └── links
        │                   └── Applications
        │                       └── tools -> ../../../../../../tools
        ├── links
        │   └── Applications -> /Applications
        └── tools
            └── app
                └── index.html

Perhaps consider updating the wiki example or let me know why this is a bad idea™.

andsens commented 11 years ago

This is a valid point, you can just go ahead and adjust that section in the wiki if you like. I didn't do it because I saw some merit in the fact that when you don't version control the link, you could make deployment specific links (like /srv instead of /var/www on some installations).

leoj3n commented 11 years ago

@andsens Are my edits to the section acceptable?

andsens commented 11 years ago

Very acceptable :-) I'll be adding the line characters like you have in the previous comment, they make things clearer.