Misc - Githubissues

andycasey commented 2 years ago

[x] Save to HDF5 instead of Pickle
[x] Commit reference spectra to Korg_data repository
[ ] Detailed abundances consistent across all photospheres?
[ ] Auto-grok for Korg-only executions, use reference spectra from Korg_data repository
[ ] Rectification by post-processing
[x] Wavelength edges (vacuum vs wavelength)
[x] Cr lines being chopped out by TurboSpectrum
[x] Continuum reported by all codes
[x] Continuum comparison
[x] Check that SME is not adding in Hydrogen lines
[x] TurboSpectrum scattering?
[x] Output opacities from SME
[x] ~Output EOS (MEQ) solutions by SME~
[ ] Magg et al. (2022) abundances
[ ] ~SME scattering~ (can't be disabled AFAIK)

andycasey commented 2 years ago

On TurboSpectrum scattering:

In DOC/Readme:

Added keywords:

PURE_LTE (true or false) for babsma. PURE_LTE=.t.
sets sigma=0. and adds up all continuous opacity
into kappa.

SCATTFRAC (0.0 to 1.0) for bsyn. This splits
the line opacity into kappa*(1.-scattfrac)
and sigma*scattfrac

In source-v19.1/input.f:

        read(charvalue,*) xmyc
      else if (keyword(1:9).eq.'SCATTFRAC') then
! fraction of line opacity to include in scattering
        read(charvalue,*) scattfrac
      else if (keyword(1:8).eq.'PURE-LTE') then
! pureLTE=.true. means take all opacity into kappa. No scattering.
! This ensures that S=B
        read(charvalue,*) pureLTE
        if (pureLTE) then
          scattfrac=0.0
        endif
      else
        print*,'input.f; bad keyword: ',keyword

We set PURE-LTE to true in our bsyn.template, which turns scattering off. I also confirmed that if we set SCATTFRAC positive and turn PURE-LTE off then it does include scattering.

andycasey commented 2 years ago

SME's EOS is stored in the external library and can't be accessed, at least not currently with PySME.

andycasey / korg_tests

Misc #2