search

andygrunwald / go-gerrit

Go client/library for Gerrit Code Review
https://godoc.org/github.com/andygrunwald/go-gerrit
MIT License
94 stars 41 forks source link

Add support for submit_requirements fields in ChangeInfo. #169

Closed simony-gke closed 1 month ago

simony-gke commented 1 month ago

As Gerrit had deprecated label functions and migrate to submit-requirements (https://gerrit-review.googlesource.com/Documentation/config-labels.html), our project (Prow, https://docs.prow.k8s.io/docs/overview/) needs to get this submit-requirements info associated with a change.

simony-gke commented 1 month ago

@andygrunwald Please review, thanks!

andygrunwald commented 1 month ago

Thanks @simony-gke for the PR. I will review it in the upcoming week.

simony-gke commented 1 month ago

@andygrunwald friendly ping. We're waiting on this, thanks.

andygrunwald commented 1 month ago

I will take this on the weekend. Sorry for the delay. Life kicked in.

Andy Grunwald

Engineering Kiosk https://engineeringkiosk.dev/ | Aiven https://aiven.io/

Web: andygrunwald.com Social: Twitter https://twitter.com/andygrunwald | GitHub https://github.com/andygrunwald | LinkedIn https://www.linkedin.com/in/andy-grunwald-09aa265a/

Simon Yang @.***> schrieb am Fr. 18. Okt. 2024 um 20:42:

@andygrunwald https://github.com/andygrunwald friendly ping. We're waiting on this, thanks.

— Reply to this email directly, view it on GitHub https://github.com/andygrunwald/go-gerrit/pull/169#issuecomment-2423038740, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACOEQDZMVQPKKDEA3HR7DTZ4FI73AVCNFSM6AAAAABPZKYTD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRTGAZTQNZUGA . You are receiving this because you were mentioned.Message ID: @.***>