search

andygrunwald / go-gerrit

Go client/library for Gerrit Code Review
https://godoc.org/github.com/andygrunwald/go-gerrit
MIT License
96 stars 40 forks source link

SetReview should return a ReviewResult #40

Closed opalmer closed 7 years ago

opalmer commented 7 years ago

The REST api for Gerrit states that:

As response a ReviewResult entity is returned that describes the applied labels and any added reviewers (e.g. yourself, if you set a label but weren’t previously a reviewer on this CL).

go-gerrit however was returning a ReviewInfo entity that was missing the reviewers and ready fields.

codecov-io commented 7 years ago

Codecov Report

Merging #40 into master will not change coverage. The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #40   +/-   ##
=======================================
  Coverage   17.94%   17.94%           
=======================================
  Files          21       21           
  Lines        1750     1750           
=======================================
  Hits          314      314           
  Misses       1403     1403           
  Partials       33       33
Impacted Files Coverage Δ
changes.go 4.63% <ø> (ø) :arrow_up:
changes_reviewer.go 0% <ø> (ø) :arrow_up:
changes_revision.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b63100d...139440f. Read the comment docs.

opalmer commented 7 years ago

@andygrunwald this one should be pretty quick. Looks like there aren't any tests to cover this...found out about it while working on gerrittest.Change.

andygrunwald commented 7 years ago

thank you!