search

andygrunwald / go-gerrit

Go client/library for Gerrit Code Review
https://godoc.org/github.com/andygrunwald/go-gerrit
MIT License
96 stars 40 forks source link

Fixed #44. #45

Closed egorse closed 6 years ago

egorse commented 6 years ago

DiffContent.A/B/AB should be []string instead of string. DiffIntralineInfo should be [][2]int.

codecov-io commented 6 years ago

Codecov Report

Merging #45 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   21.23%   21.23%           
=======================================
  Files          21       21           
  Lines        1775     1775           
=======================================
  Hits          377      377           
  Misses       1353     1353           
  Partials       45       45
Impacted Files Coverage Δ
changes.go 16.14% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e9ccf52...0655566. Read the comment docs.

andygrunwald commented 6 years ago

LGTM as well. But i follow @shurcooL comment idea.

andygrunwald commented 6 years ago

Thank you.