search

andygrunwald / go-gerrit

Go client/library for Gerrit Code Review
https://godoc.org/github.com/andygrunwald/go-gerrit
MIT License
96 stars 40 forks source link

Add Reviewers field to ChangeInfo #59

Closed anandsudhir closed 6 years ago

anandsudhir commented 6 years ago

Add Reviewers field to ChangeInfo

from: https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-info

Right now, this is the only field missing from the entities that I need to finish up creating a Gerrit widget on https://github.com/senorprogrammer/wtf

codecov-io commented 6 years ago

Codecov Report

Merging #59 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #59   +/-   ##
=======================================
  Coverage   22.59%   22.59%           
=======================================
  Files          21       21           
  Lines        1797     1797           
=======================================
  Hits          406      406           
  Misses       1337     1337           
  Partials       54       54
Impacted Files Coverage Δ
changes.go 16.14% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5632c7f...78b0a75. Read the comment docs.

anandsudhir commented 6 years ago

Although the change is just to add one field, it, unfortunately, looks bigger as I had to add a space on all those lines to ensure that they are aligned.

andygrunwald commented 6 years ago

Thank you :)

dmitshur commented 6 years ago

Although the change is just to add one field, it, unfortunately, looks bigger as I had to add a space on all those lines to ensure that they are aligned.

For anyone who doesn't already know, it's possible to add ?w=1 query parameter on GitHub to see the diff ignoring whitespace differences.