search

andygrunwald / go-gerrit

Go client/library for Gerrit Code Review
https://godoc.org/github.com/andygrunwald/go-gerrit
MIT License
96 stars 40 forks source link

feat: project access method #74

Closed chyroc closed 5 years ago

chyroc commented 5 years ago

image

https://gerrit-review.googlesource.com/Documentation/rest-api-projects.html

codecov-io commented 5 years ago

Codecov Report

Merging #74 into master will increase coverage by 0.82%. The diff coverage is 58.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   22.82%   23.64%   +0.82%     
==========================================
  Files          21       22       +1     
  Lines        1801     1844      +43     
==========================================
+ Hits          411      436      +25     
- Misses       1333     1342       +9     
- Partials       57       66       +9
Impacted Files Coverage Δ
access.go 75% <ø> (ø) :arrow_up:
projects_access.go 58.13% <58.13%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5959a9b...3fc1d85. Read the comment docs.

chyroc commented 5 years ago

@andygrunwald please please see this pr

chyroc commented 5 years ago

@andygrunwald I am very sorry to bother you, I beg you to look at this pr, thank you very much.

andygrunwald commented 5 years ago

@chyroc Looks good to me. I have only a small remark regarding the filename of the test file. After this is done, we are good to go.

chyroc commented 5 years ago

@andygrunwald done, please see again

chyroc commented 5 years ago

hi... I fix it, please see again

andygrunwald commented 5 years ago

Thank you!