search

andygrunwald / go-gerrit

Go client/library for Gerrit Code Review
https://godoc.org/github.com/andygrunwald/go-gerrit
MIT License
96 stars 40 forks source link

omitempty for AbandonInput.Notify and AbandonInput.NotifyDetails fields #89

Closed chizhg closed 3 years ago

chizhg commented 3 years ago

Set omitempty for AbandonInput.Notify and AbandonInput.NotifyDetails fields.

The reason for this change is that if NotifyDetails is not set, notify_details will be unmarshalled as nill in the json string, which isn't allowed by the Gerrit server and will result in a 400 Bad Request response.

andygrunwald commented 3 years ago

Thanks a lot, @chizhg. Do you need a new tag or do you refer to the current sha in your modules?

chizhg commented 3 years ago

Using the current sha is fine for me. Thanks for merging it!

andygrunwald commented 3 years ago

Great. Enjoy your day. And thanks again for the contribution. Much appreciated.