andygrunwald / go-gerrit

Go client/library for Gerrit Code Review
https://godoc.org/github.com/andygrunwald/go-gerrit
MIT License
96 stars 40 forks source link

changes: fill in the rest of Changes.ChangeInput #97

Closed wwade closed 3 years ago

wwade commented 3 years ago

The ChangeInput type was recently added with just the bare-bones fields in place. This commit adds the rest of the fields per the current gerrit documentation.

Updated TestChangesService_CreateChange to have stronger assertions about empty values (recursively checks nested structures), and added test cases specific to exercise ChangeInput.Merge and ChangeInput.Author.

This change is a result of the discussion on PR #96.

andygrunwald commented 3 years ago

Thanks a lot @wwade!