search

andygrunwald / go-jira

Go client library for Atlassian Jira
https://pkg.go.dev/github.com/andygrunwald/go-jira?tab=doc
MIT License
1.44k stars 458 forks source link

Servicedesk Get/Add Organizations - serviceDeskID should allow string type #418

Open james-cast opened 2 years ago

james-cast commented 2 years ago

Is your feature request related to a problem? Please describe.

In the documentation, it states that the serviceDeskID provided should be an integer.

serviceDeskId REQUIRED integer The ID of the service desk from which the organization list will be returned. This can alternatively be a project identifier.

https://developer.atlassian.com/cloud/jira/service-desk/rest/api-group-organization/#api-rest-servicedeskapi-servicedesk-servicedeskid-organization-get

However, this is not 100% correct it can also be a project identifier (a string) as described here: https://developer.atlassian.com/cloud/jira/service-desk/rest/intro/#project-identifiers

Describe the solution you'd like

Update servicedesk.go signatures to allow strings instead of only int type for serviceDeskID.

github-actions[bot] commented 2 years ago

Hi! Thank you for taking the time to create your first issue! Really cool to see you here for the first time. Please give us a bit of time to review it.

andygrunwald commented 1 year ago

Hey,

I am very sorry that this issue has been open for a long time with no final solution. We work on this project in our spare time, and sometimes, other priorities take over. This is the typical open source dilemma.

However, there is news: We are kicking off v2 of this library 🚀

To provide visibility, we created the Road to v2 Milestone and calling for your feedback in https://github.com/andygrunwald/go-jira/issues/489

The development will take some time; however, I hope you can benefit from the changes. If you seek priority development for your issue + you like to sponsor it, please contact me.

What does this mean for my issue?

We will work on this issue indirectly. This means that during the development phase, we aim to tackle it. Maybe in a different way like it is currently handled. Please understand that this will take a while because we are running this in our spare time.

Final words

Thanks for using this library. If there is anything else you would like to tell us, let us know!