TODO: check TODO on the comments

lujiashun commented 2 years ago

4:./sql/field.h:635:  // stonedb8 TODO: fix engine_convert.cpp #42
5:./sql/gen_lex_token.cc:147:const int MY_MAX_TOKEN = 1201; // stonedb8 TODO: org 1200, +1
11:./sql/item_sum.h:522:  // stonedb8 TODO
29:./sql/sql_lex.cc:4401:// stonedb8 start TODO: a better way.
34:./storage/tianmu/base/fmt/format.h:274:// stonedb8 TODO: maybe boost version
42:./storage/tianmu/core/aggregation_algorithm.cpp:313:            t->GetAttrP(i)->OverrideStringSize(tianmu_group_concat_max_len); // TODO: stonedb8
81:./storage/tianmu/core/engine.cpp:1504:    //query_cache.invalidate(thd, table_list, 0);  // stonedb8 TODO: query_cache is deleted by MySQL8
87:./storage/tianmu/core/engine.cpp:1734:  bool local_load = false; // for_exporter ? false : (bool)(thd.lex)->local_file; // stonedb8 TODO: mysql_load
88:./storage/tianmu/core/engine.cpp:1735:  uint value_list_elements = 0; // (thd.lex)->load_value_list.elements; // stonedb8 TODO: mysql_load
97:./storage/tianmu/core/engine_execute.cpp:116:  // stonedb8 TODO
107:./storage/tianmu/core/engine_execute.cpp:274:  if (select_lex->join /*&& *Query::IsLOJ(select_lex->join_list)*/) // stonedb8 TODO
115:./storage/tianmu/core/engine_execute.cpp:364:        select_lex->set_join(join); // stonedb8 TODO
121:./storage/tianmu/core/engine_execute.cpp:584:                sl->join->select_options = (select_limit_cnt == HA_POS_ERROR /*|| sl->braces*/) // stonedb8 TODO
146:./storage/tianmu/core/query.cpp:1121:    if (!Item2CQTerm(&*ifield, zero_term, tmp_table, filter_type)) return CondID(-1); // stonedb8 TODO
147:./storage/tianmu/core/query.cpp:1124:  if (!Item2CQTerm(&*ifield, first_term, tmp_table, filter_type)) return CondID(-1); // stonedb8 TODO
149:./storage/tianmu/core/query.cpp:1136:    if (!Item2CQTerm(&*ifield, next_term, tmp_table, filter_type)) return CondID(-1); // stonedb8 TODO
154:./storage/tianmu/core/query_compile.cpp:291:// stonedb8 start fix List<Item> to mem_root_deque<Item *> #49 TODO
170:./storage/tianmu/core/query_compile.cpp:1080:// stonedb8 start  #define is deleted TODO
172:./storage/tianmu/core/query_compile.cpp:1111:// stonedb8 start fix List<Item> to mem_root_deque<Item *> #49 TODO
184:./storage/tianmu/handler/tianmu_handler.cpp:556:int TianmuHandler::rename_table(const char *from, const char *to, const dd::Table *from_table_def, dd::Table *to_table_def) {   // stonedb8 TODO
185:./storage/tianmu/handler/tianmu_handler.cpp:672:int TianmuHandler::open(const char *name, [[maybe_unused]] int mode, [[maybe_unused]] uint test_if_locked, [[maybe_unused]] const dd::Table *table_def) { // stonedb8 TODO
190:./storage/tianmu/handler/tianmu_handler.cpp:1094:  // stonedb8 TODO: HA_EXTRA_NO_CACHE is deleted
191:./storage/tianmu/handler/tianmu_handler.cpp:1129:// stonedb8 TODO: register_query_cache_table is deleted
192:./storage/tianmu/handler/tianmu_handler.cpp:1153:int TianmuHandler::delete_table(const char *name, const dd::Table *table_def) { // stonedb8 TODO
193:./storage/tianmu/handler/tianmu_handler.cpp:1193:int TianmuHandler::create(const char *name, TABLE *table_arg, [[maybe_unused]] HA_CREATE_INFO *info, dd::Table *table_def) { // stonedb8 TODO
194:./storage/tianmu/handler/tianmu_handler.cpp:1216:int TianmuHandler::truncate(dd::Table *table_def) { // stonedb8 TODO
195:./storage/tianmu/handler/tianmu_handler.cpp:1459:                                   const dd::Table *old_table_def [[maybe_unused]], dd::Table *new_table_def [[maybe_unused]]) {  // stonedb8 TODO
196:./storage/tianmu/handler/tianmu_handler.cpp:1482:                                          dd::Table *new_table_def [[maybe_unused]]) {  // stonedb8 TODO
213:./storage/tianmu/handler/tianmu_handler_com.cpp:66:handler *rcbase_create_handler(handlerton *hton, TABLE_SHARE *table, bool partitioned, MEM_ROOT *mem_root) {  // stonedb8 TODO
214:./storage/tianmu/handler/tianmu_handler_com.cpp:125:  if (!( /*thd->no_errors != 0 || */ thd->killed || thd->transaction_rollback_request)) { // stonedb8 TODO: no_errors is deleted

andyli029 commented 2 years ago

const dd::Table *from_table_def

is added by MySQL 8.0, need Evaluate it.

andyli029 commented 2 years ago

From Query::Compile

    if (!sl->join)
        {
// stonedb8 start
      TIANMU_LOG(LogCtl_Level::ERROR, "sl->join is nil!!!!");

//            sl->add_active_options(SELECT_NO_UNLOCK);
//            JOIN *join = new JOIN(sl->master_unit()->thd, sl);
//
//            if (!join) {
//
//                sl->cleanup(0);
//                return true;
//            }
//            sl->set_join(join);
// stonedb8 end
     }

andyli029 commented 2 years ago

// stonedb8
/*
const char **TianmuHandler::bas_ext() const {
  static const char *ha_rcbase_exts[] = {common::TIANMU_EXT, 0};
  return ha_rcbase_exts;
}
*/