search

andymatuschak / orbit

Experimental spaced repetition platform for exploring ideas in memory augmentation and programmable attention
https://withorbit.com
Other
1.71k stars 54 forks source link

Removing local dependency references from backend #219

Closed andymatuschak closed 3 years ago

andymatuschak commented 3 years ago

Wanted to run this by you @kirkbyo, since it's a bit weird.

backend is deployed to Cloud Functions, but the server can't actually access local packages like @withorbit/api: they're not actually published to NPM. So our strategy has been to bundle the local dependencies into a single .js which then gets deployed. But to make this strategy work, I have to remove the local dependencies from package.json (otherwise, the Firebase servers try to install them along with all the other dependencies, and fail).

I noticed that you re-added these dependencies recently. Was something breaking when they weren't declared? Everything seems to work appropriately with them gone as far as I can tell, but I wanted to run it past you.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

andymatuschak commented 3 years ago

Cool, thanks for confirming.