search

angadhn / SpacecraftDynamics

Executable Textbook for Spacecraft Dynamics
http://www.angadhn.com/SpacecraftDynamics/
4 stars 10 forks source link

Lecture 3 and image #12

Closed nozzington closed 2 months ago

nozzington commented 3 months ago

first PR for lecture 3 can change whatever needs to be, have tried to follow formatting as shown in Mitansh's lecture 7. Please say what i can change and i will do so as soon as possible!

review-notebook-app[bot] commented 3 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

angadhn commented 2 months ago

Might be that you forgot the protocol on opening PRs. You need to submit PRs from a branch labeled under a specific lecture name. You shouldn't submit changes from main. I foresee issues with working off of main for you. Instead what you should have done is created two branches: one called Lecture3 and another called Lecture6.

Can you work by adhering to this protocol please (as discussed in the last meeting)?

angadhn commented 2 months ago

Also, file names should also be consistent with directory name. Uppercase L and no whitespace. So Lecture3.ipynb and Lecture6.ipynb.

angadhn commented 2 months ago

Also, as discussed in our meetings, all images relevant to a lecture must be under a specific directory called images or imgs. Worth referring to the structure of Lecture 7 by @mitanshc and also seeing how he references images in his Lecture7.ipynb file.

angadhn commented 2 months ago

Specific to the textbook content. I see that you are using arrows for vectors. You can see that for the textbook. we have chosen to use boldface terms for vectors. So please remove the arrows and make use of ${\bf r}$ and ${\bf v}$ and so on. You can get that by in an equation by using {\bf r} and {\bf v}. Also, use the brackets carefully. {\bf v}_{perifocal} for ${\bf v}_{perifocal} $. I think in your lecture 3, you have boldface for the subscript.