angadhn / SpacecraftDynamics

Executable Textbook for Spacecraft Dynamics
http://www.angadhn.com/SpacecraftDynamics/
4 stars 10 forks source link

Issue on page /unsolved_problems/PS1/PS1.html #27

Closed adrulpz closed 1 month ago

adrulpz commented 2 months ago

Hi Angadh, just a couple of observations on this set.

Q1: N and E could be in bold letters. The last two expressions still have the "$" symbol and is missing a space just before "and". Q2: same problem, v still have the "$" symbol Q3: same problem with the acceleration expression Q4: after "given by: "needs to be rewritten, there are no spaces, and it is all as a math expression

angadhn commented 2 months ago

great. How about making the changes? Top-level procedure and I think @Joosty can guide too):

  1. fork the repo.
  2. clone your fork.
  3. create a branch called "PS1_Fix".
  4. Make changes.
  5. Commit and push changes to fork.
  6. Open a PR.

Procedures are outlined in greater detail here: https://github.com/angadhn/SpacecraftDynamics/blob/main/CONTRIBUTING.md

Joosty commented 2 months ago

Happy to help if you need to be ran through anything @adrulpz :) can hop on a call if you need!

adrulpz commented 2 months ago

Thanks, @Joosty. I appreciated it. I will make the changes later today. If I need help I will reach out :) And @angadhn, I think you forgot the link 😅

angadhn commented 2 months ago

@adrulpz comment updated ;)

angadhn commented 1 month ago

Fixed in PR29.