search

angadhn / SpacecraftDynamics

Executable Textbook for Spacecraft Dynamics
http://www.angadhn.com/SpacecraftDynamics/
4 stars 10 forks source link

Uploading Lecture 11 and it's images #9

Closed mitanshc closed 2 months ago

mitanshc commented 4 months ago

This is the first upload of Lecture 11 on it's own branch. I've made the changes which were required for Lecture 7. There is a little python thing I did, which may or may not look weird on publish.

review-notebook-app[bot] commented 4 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

mitanshc commented 4 months ago

Honestly not sure what happened here. It failed the check like Lecture 12 right now. I fiddled around and kept updating and it passed somehow.

angadhn commented 2 months ago

@mitanshc sorry- it has taken me a while to get to this PR. Working on it today. As an aside, have you gotten a local building of Jupyter books working for yourself? More on that here for windows: https://jupyterbook.org/en/stable/advanced/windows.html

angadhn commented 2 months ago

@mitanshc first change: please rename the file to Lecture11. Currently it has a whitespace between the Lecture and 11.

angadhn commented 2 months ago

@mitanshc please use ^\circ instead of \degree for the angles. Some issues with the way this textbook renders in the html output even though it looks fine in ipynb files. Thanks!

angadhn commented 2 months ago

I think your perturbation plots are great.

  1. Can you remove the stuff before import statements in the below: image

  2. Can you add some justification on why y1, y2, y3, y4 equations are what they are or how you got these functions? Add these lines to after the plot is generated. Thanks!

mitanshc commented 2 months ago

I think your perturbation plots are great.

  1. Can you remove the stuff before import statements in the below: image
  2. Can you add some justification on why y1, y2, y3, y4 equations are what they are or how you got these functions? Add these lines to after the plot is generated. Thanks!

I’ll have a look at this later today. Regarding the equations, I didn’t have a particular method. I did a lot of trial and error to make the graphs/equations look like the hand drawn graphs from the original lecture notes. This is why I was trying to hide the input/code.

mitanshc commented 2 months ago

@mitanshc sorry- it has taken me a while to get to this PR. Working on it today. As an aside, have you gotten a local building of Jupyter books working for yourself? More on that here for windows: https://jupyterbook.org/en/stable/advanced/windows.html

I used to have one through Anaconda. I’ve since reset my PC and I’ve been using the main Python along with VSCode. Would you recommend Jupyterbooks over this?

angadhn commented 2 months ago

@mitanshc sorry- it has taken me a while to get to this PR. Working on it today. As an aside, have you gotten a local building of Jupyter books working for yourself? More on that here for windows: https://jupyterbook.org/en/stable/advanced/windows.html

I used to have one through Anaconda. I’ve since reset my PC and I’ve been using the main Python along with VSCode. Would you recommend Jupyterbooks over this?

No- it's okay. Stick with what you have for now. Sorry for confusing you about this. But let's have a talk about this another time in the context of your project. Note that, especially in your case, I would seriously consider getting a virtual machine of Linux running on your computer. Or a dual boot of Linux, if you are confident at setting that up. again, we can discuss this later.

mitanshc commented 2 months ago

Hello, I got caught up in my video and only made a few edits for demonstration purposes. I didn’t get around to fixing the code section of the lecture and I just caught a couple more \degree in my markdown. Though I had a look on the live website and it doesn’t seem noticeable on a phone. Would you like me to make those edits on a separate branch but keep the file names and everything the same and create a new PR?

On a side note, I managed to get Jupyter-books working to build a book. Though I haven’t managed to edit beyond the beyond the title yet.

angadhn commented 2 months ago

All good- I fixed up the little issues with the degrees signs myself. Thanks for working on the video. Very helpful!