angular-redux / router

Keep your Angular2+ router state in Redux
MIT License
28 stars 7 forks source link

Support Ivy compiler #29

Open ChugunovD opened 4 years ago

ChugunovD commented 4 years ago

This is a...

What toolchain are you using for transpilation/bundling?

Environment

NodeJS Version: v10.15.3 Typescript Version: ~3.6.4 Angular Version: ~9.0.0-rc.6 @angular-redux/store version: ^9.0.0 @angular/cli version: (if applicable) ~9.0.0-rc.6 OS: Windows 10

Link to repo showing the issus

Try to build any Angular project based on Ivy compiller

Expected Behaviour:

Compilation in Prod Successfull

Actual Behaviour:

Compilation Failed

Stack Trace/Error Message:

ERROR in ../node_modules/@angular-redux/router/lib/es5/src/index.d.ts:6:23 - error TS-996005: NgReduxRouterModule.forRoot returns a ModuleWithProviders type without a generic type argument. Please add a generic type argument to the ModuleWithProviders type. If this occurrence is in library code you don't control, please contact the library authors.

6 static forRoot(): ModuleWithProviders;



### Additional Notes:
There are need to add Generic for return type ModuleWithProviders in index.ts for NgReduxRouterModule.
Now: `static forRoot(): ModuleWithProviders {`
Will be: `static forRoot(): ModuleWithProviders<NgReduxRouterModule> {`
bstaley commented 4 years ago

Any update on this? Looks like @ChugunovD has provided a fix. Will anyone be able to make the changes?

idanaim commented 4 years ago

?