feat: convert Navigation component to Analog SFC

nartc commented 5 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/ngneat/transloco/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: part of #247

What is the new behavior?

Navigation and App are now Analog SFC

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

netlify[bot] commented 5 months ago

Deploy Preview for angular-hub ready!

Name	Link
Latest commit	2f111a2dc14b253bc157fae978a4da01442979ce
Latest deploy log	https://app.netlify.com/sites/angular-hub/deploys/6658e78e3650b10008fbe9a3
Deploy Preview	https://deploy-preview-287--angular-hub.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

geromegrignon commented 5 months ago

Thanks @nartc! I was about to create an issue for the community to contribute as there was a refactoring opportunity for people willing to contribute. Awesome to get it with analog authoring format!

geromegrignon commented 5 months ago

I'm going to investigate, serving the app locally works as expected but there are some regressions on production (forms missing and burger menu not visible on small screens):

geromegrignon commented 5 months ago

Broken content is all about PrimeNG components.

angular-sanctuary / angular-hub