angular-sanctuary / angular-hub

Curated list of Angular events and communities
https://angular-hub.com/
MIT License
50 stars 29 forks source link

feat: 🎸 add generators to create community/event/podcast #314

Closed ilirbeqirii closed 4 months ago

ilirbeqirii commented 5 months ago

✅ Closes: #164

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

We are adding comms, events, and podcasts by manually modifying JSON files.

Issue Number: #164

What is the new behavior?

Run the generators to add a new community, event, or podcast.

Does this PR introduce a breaking change?

Other information

netlify[bot] commented 5 months ago

Deploy Preview for angular-hub ready!

Name Link
Latest commit 866fa5195a4422f385ad79107b1013b013162b56
Latest deploy log https://app.netlify.com/sites/angular-hub/deploys/66787d29cd50250008826047
Deploy Preview https://deploy-preview-314--angular-hub.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ilirbeqirii commented 5 months ago

@geromegrignon I have created the schematics for adding a new community/event/podcast. I tried to identify based on the existing data and the schemas you have made to separate required and non-required props.

These are the simplest versions of them (based on me), I am open to your feedback and enhancing them more and more.

p.s. Unit Tests are to be added soon.

geromegrignon commented 5 months ago

Hi @ilirbeqirii, I'll review it tomorrow.

geromegrignon commented 4 months ago

Thanks @ilirbeqirii !