angular-sanctuary / angular-hub

Curated list of Angular events and communities
https://angular-hub.com/
MIT License
50 stars 29 forks source link

feat: add japanese comunities and podcasts #317

Closed ver-1000000 closed 4 months ago

ver-1000000 commented 4 months ago

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

Add japan informations.

Does this PR introduce a breaking change?

Other information

netlify[bot] commented 4 months ago

Deploy Preview for angular-hub ready!

Name Link
Latest commit f2cdda62b90261274f2362db05e75004c034e8e9
Latest deploy log https://app.netlify.com/sites/angular-hub/deploys/667e7a53f7c5030008e7dca0
Deploy Preview https://deploy-preview-317--angular-hub.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

geromegrignon commented 4 months ago

Hi @ver-1000000, thanks for your contribution.

Are the following communities still active? Based on the website provided, there were no events for years. As the goal is to provide a way for the community to meet people, I want to avoid listing no longer active communities.

ver-1000000 commented 4 months ago

Thanks, @geromegrignon.

I apparently did not understand the policy of this repository.

I will immediately review the PR as suggested and repush.

geromegrignon commented 4 months ago

Hi thanks for the change, I'll update the CONTRIBUTING guide for a more explicite description.

I'll see in another PR how to handle StartupAngular and ng-japan to evolve the current schema so Communities podcasting their content are listing under Podcasts, rather than being 2 different entries.

geromegrignon commented 4 months ago

@all-contributors please add @ver-1000000 for code

allcontributors[bot] commented 4 months ago

@geromegrignon

I've put up a pull request to add @ver-1000000! :tada:

geromegrignon commented 4 months ago

Hi @ver-1000000, I'll open addition of all communities soon (to add the ones removed from your first commit). I'll update the project as a prerequisite:

If listing an inactive community might not be useful to find a local event, it might still be a way to know if there is some possible revival as a community member wanting to be involved.