angular-sanctuary / angular-hub

Curated list of Angular events and communities
https://angular-hub.com/
MIT License
50 stars 29 forks source link

[Bug]: When clicked, October events show no details #340

Closed jdegand closed 3 months ago

jdegand commented 4 months ago

Relevant scope

angular application

Description

october-events-bug

Maybe, there is a typo for the October events.

Do you want to contribute with a pull request?

No

jdegand commented 4 months ago

I think this is related to the fact that the event ng-de spans multiple days.

jdegand commented 4 months ago

The December 5, ng-be, event also doesn't show any details when clicked. Looking in community.json, the endDate field is not included in every model. I think the valibot schema doesn't have an optional endDate property, but changing the schema doesn't seem to be enough to fix the problem so maybe there is also a logic error.

Using event.url in event-section for trackBy could be problematic if an event is multiple dates? There really isn't anything unique in the event model.

geromegrignon commented 3 months ago

fixed with #360