fix 109: trim spaces to fix one-time expression detection

OACDesigns commented 7 years ago

this fixes https://github.com/angular/angular-hint/issues/109 allowing for both {{ :: and {{:: which are valid syntax for one-time bindings.

The same is done in Angular 1.5.8 when detecting one-time binding in string expressions.

googlebot commented 7 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

OACDesigns commented 7 years ago

I signed it!

googlebot commented 7 years ago

CLAs look good, thanks!

gkalpak commented 7 years ago

@OACDesigns, thanks for fixing this. Could you also add a test for the fix in test/scopes.spec.js?

angular / angular-hint

fix 109: trim spaces to fix one-time expression detection #122