DevGuide lifecycle-hooks issues

angular / angular.io

Website for the Angular project (see github.com/angular/angular for the project repo)

https://angular.io

MIT License

1.03k stars 880 forks source link

DevGuide lifecycle-hooks issues #1292

Open chalin opened 8 years ago

chalin commented 8 years ago

[ ] mismatch between Spy Directive video and TS / Dart app behavior: there is no Spy #4 onInit generated. It goes directly to #5.
[ ] I don't understand the following statement in the prose; consider revising:

We also see that the ngOnChanges method is called in contradiction of the incorrect API documentation.
[ ] Counter spy is not fully explained in the prose (maybe it is an exercise for the reader to study it?).
[ ] See #1286.

Drumarcco commented 7 years ago

There's also an issue https://github.com/angular/angular/issues/10221 about the documentation stating some hooks are only available to components, when in reality they're also available to directives.

Working on it, I'll make a PR soon.