refactor!: fixing all static analysis warnings

angulardart-community / angular

Fast and productive web framework provided by Dart.

https://pub.dev/packages/ngdart

MIT License

114 stars 14 forks source link

refactor!: fixing all static analysis warnings #31

Closed ykmnkmi closed 1 year ago

ykmnkmi commented 2 years ago

@GZGavinZhao I think we need to bump the minimal SDK version to 2.18.0.

GZGavinZhao commented 2 years ago

@ykmnkmi I'm okay with it. You also might need to lock build_modules to ^4.0.7

GZGavinZhao commented 2 years ago

Oh also, if you would like to sign your commits when your PR is ready that would be great. So far I've been squashing the commits and signing them using my keys (which is why you sometimes see commits are authored by you but committed by me), and I'm happy to keep doing so, but if it's convenient for you to sign them then that would be great :)

ykmnkmi commented 1 year ago

@GZGavinZhao thanks for helping with commits and PR's.