search

angulardart-community / angular

Fast and productive web framework provided by Dart.
https://pub.dev/packages/ngdart
MIT License
114 stars 14 forks source link

refactor(ngcompiler): fix all static warnings. #50

Closed ykmnkmi closed 1 year ago

ykmnkmi commented 1 year ago

@GZGavinZhao, I don't think it's breaking PR, as it's not a public package. Strange fails, could they be related to Chrome?

denniskaselow commented 1 year ago

Because I found those fails interesting, I took a look at it. The tests use intl 0.18.1 which was published yesterday and one of the changes was this:

https://github.com/dart-lang/i18n/blame/468f08c6a08b81879e769f80c4a6f7b0d763e4a1/pkgs/intl/test/date_time_strict_test.dart#L52

Instead of a normal whitespace it's now a \u202F or Narrow No-Break Space (NNBSP).

ykmnkmi commented 1 year ago

@denniskaselow thank you.

GZGavinZhao commented 1 year ago

@GZGavinZhao, I don't think it's breaking PR, as it's not a public package. Strange fails, could they be related to Chrome?

I agree that this doesn't need to be a breaking change. Also thank you @denniskaselow for investigating the issue!