search

angularsen / UnitsNet

Makes life working with units of measurement just a little bit better.
https://www.nuget.org/packages/UnitsNet/
MIT No Attribution
2.66k stars 382 forks source link

Added SiDecitonne mass unit of measure. #1333

Closed IhorMukhortv closed 11 months ago

angularsen commented 12 months ago

At first I was sure this was a typo 😄

  1. It seems the unit centner is also called quintal. Which name should we use?

  2. There are two different units with the same name. Do we need to add both? And should we name them so it is clear which unit we mean?

In British English, it referred to the hundredweight; in American English, it formerly referred to an uncommon measurement of 100 kg (220 lb).

https://en.wikipedia.org/wiki/Quintal

We have previously used gal (U.S.) vs gal (imp.) to disambiguate US and imperial units. We could maybe use centner (U.S.) and centner (imp.) to match that, or similar for "quintal" if we go with that name.

https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit#abbreviation-naming-conventions

IhorMukhortv commented 12 months ago

At first I was sure this was a typo 😄

  1. It seems the unit centner is also called quintal. Which name should we use?
  2. There are two different units with the same name. Do we need to add both? And should we name them so it is clear which unit we mean?

In British English, it referred to the hundredweight; in American English, it formerly referred to an uncommon measurement of 100 kg (220 lb).

https://en.wikipedia.org/wiki/Quintal

We have previously used gal (U.S.) vs gal (imp.) to disambiguate US and imperial units. We could maybe use centner (U.S.) and centner (imp.) to match that, or similar for "quintal" if we go with that name.

https://github.com/angularsen/UnitsNet/wiki/Adding-a-New-Unit#abbreviation-naming-conventions

I have found a suitable standardized name - 'decitonne.' I haven't delved into the details of the U.S. and Imperial measurement systems. In my opinion, there are two primary systems: Metric (or SI, as the modern variant) and Imperial. Considering that 'decitonne' could still cause confusion, I suggest adding 'decitonne (SI).' In the code, this might appear as 'SiDecitonne.'

If you have any further thoughts or concerns, please let me know, and we can proceed with the implementation. Thank you for your attention to detail!

It appears that 'Hundredweight' is not included in the PDF document provided in the Wiki under 'Adding a New Unit'.(https://unece.org/fileadmin/DAM/cefact/recommendations/rec20/rec20_rev3_Annex2e.pdf)

Best regards.

IhorMukhortv commented 11 months ago

Hi, it's frustrating that my straightforward suggestion—just adding one unit of measurement to your structure—was overlooked. I'm disappointed in the lack of attention to such a simple improvement. I regret investing my time in this, but regardless, I wish you success in your development endeavors.

angularsen commented 11 months ago

@IhorMukhortv I think you need to adjust your expectations. This is the nature of many open source projects that are maintained on evenings and nights outside busy work life and family life. This was also not a simple improvement, there were questions and stuff to figure out.