search

anholt / libepoxy

Epoxy is a library for handling OpenGL function pointer management for you
Other
680 stars 161 forks source link

Fix static build (DllMain) #266

Open melroy89 opened 2 years ago

melroy89 commented 2 years ago

Do not include the DllMain entry point in the static build, only when it's a shared build.

melroy89 commented 2 years ago

@ebassi Maybe you want to look at this PR?

ebassi commented 2 years ago

I receive mail for all PRs/issues; I don't always have time to review things immediately: libepoxy is not the only project I work on.

ebassi commented 2 years ago

It would be nice to have some test, or a CI pipeline job, that checks the static build on Windows and ensures that a) it works and b) it does not regress.

melroy89 commented 2 years ago

I receive mail for all PRs/issues; I don't always have time to review things immediately: libepoxy is not the only project I work on.

I understand, no blame.

It would be nice to have some test, or a CI pipeline job, that checks the static build on Windows and ensures that a) it works and b) it does not regress.

I agree. I guess, we can extend the github action workflow file with a static build: https://github.com/anholt/libepoxy/blob/master/.github/workflows/msys2.yml

melroy89 commented 2 years ago

Ping? (sorry to just bother you, otherwise I don't see this getting merged)

melroy89 commented 2 years ago

Any feedback?

theartful commented 2 years ago

I would appreciate if this is supported upstream as well.

melroy89 commented 2 years ago

I would appreciate if this is supported upstream as well.

Me too that is why I created this pr. @ebassi @anholt somebody?

dg0yt commented 1 year ago

Is it really enough to not compile DllMain? Wouldn't it take an alternative way to do the initialization which is in the body of this function?