search

anidl / multi-downloader-nx

Downloader for Crunchyroll, Hidive, AnimeOnegai, and AnimationDigitalNetwork with CLI and GUI
MIT License
265 stars 44 forks source link

BUG - GUI Keeps Crashing on macos #258

Closed XxUnkn0wnxX closed 2 years ago

XxUnkn0wnxX commented 2 years ago

Program version

3.0.0

Service

Irrelevant

Command used

N/A

Show ID

N/A

Episode

N/A

Console Output

I either Get this:

Uncaught Exception:
Error: EROFS: read-only file system, mkdir '/private/var/folders/m6/vln7p7nx73l3r5q5bg7h1n9h0000gn/T/AppTranslocation/F72DD097-7669-4E4D-BBFD-F7124782312B/d/multi-downloader-nx.app/Contents/Resources/app/gui/electron/src/logs'
at Object.mkdirSync (node:fs:1334:3)
at /private/var/folders/m6/vln7p7nx73l3r5q5bg7h1n9h0000gn/T/AppTranslocation/F72DD097-7669-4E4D-BBFD-F7124782312B/d/multi-downloader-nx.app/Contents/Resources/app/gui/electron/src/index.js:64:26
at Object.<anonymous> (/private/var/folders/m6/vln7p7nx73l3r5q5bg7h1n9h0000gn/T/AppTranslocation/F72DD097-7669-4E4D-BBFD-F7124782312B/d/multi-downloader-nx.app/Contents/Resources/app/gui/electron/src/index.js:66:7)
at Module._compile (node:internal/modules/cjs/loader:1116:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1169:10)
at Module.load (node:internal/modules/cjs/loader:988:32)
at Module._load (node:internal/modules/cjs/loader:829:12)
at Function.c._load (node:electron/js2c/asar_bundle:5:13331)
at Object.<anonymous> (node:electron/js2c/browser_init:193:3197)
at Object../lib/browser/init.ts (node:electron/js2c/browser_init:193:3401)

Screen Shot 2022-02-17 at 8 04 57 am

Or this when trying to run Gui via terminal.

[77587:0217/080614.848633:ERROR:mach_port_rendezvous.cc(310)] bootstrap_look_up com.electron.multi-downloader-nx.MachPortRendezvousServer.77578: Unknown service name (1102)
[77587:0217/080614.850825:ERROR:child_thread_impl.cc(226)] Mach rendezvous failed, terminating process (parent died?)

Additional Information

Video Of Crash just watch as it crashes every time i open its like 1 seconds it opens & insta closes not even sure where logs are for this.

izu-co commented 2 years ago

Since I have no Mac I couldn’t test it for make unfortunately- I will investigate the source later

Thanks for the report

izu-co commented 2 years ago

On error i see right now is that the file system seems to be read only. This could be a permission error or an error with electron

XxUnkn0wnxX commented 2 years ago

I did set full disk access to it in system preferences, from the video demo that's with full disk access but it instantly closes/crashes.

izu-co commented 2 years ago

I can't build a 'test version' for you but can you try to build from source by running npm run build-macos-gui

XxUnkn0wnxX commented 2 years ago

well it built still getting on commit e6d5dab21a8b9bccc7ba78ae97a741a0a773c11e

[248:0218/213823.584547:ERROR:mach_port_rendezvous.cc(310)] bootstrap_look_up com.electron.multi-downloader-nx.MachPortRendezvousServer.1: Unknown service name (1102)
[248:0218/213823.586852:ERROR:child_thread_impl.cc(226)] Mach rendezvous failed, terminating process (parent died?

same thing like in the video demo where it opens & closes in under a second.

Full build log:

❯ npm run build-macos-gui

> multi-downloader-nx@3.0.0 prebuild-macos-gui
> npm run tsc

> multi-downloader-nx@3.0.0 tsc
> ts-node tsc.ts

Removing lib dir... ✓
Running tsc... ✓
Building react... 
up to date, audited 1434 packages in 3s

178 packages are looking for funding
  run `npm fund` for details

9 moderate severity vulnerabilities

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> react@0.1.0 build
> react-scripts build

Creating an optimized production build...

Compiled with warnings.

src/App.tsx
  Line 2:10:  'Button' is defined but never used                 @typescript-eslint/no-unused-vars
  Line 2:18:  'TextField' is defined but never used              @typescript-eslint/no-unused-vars
  Line 2:29:  'Box' is defined but never used                    @typescript-eslint/no-unused-vars
  Line 3:10:  'messageChannelContext' is defined but never used  @typescript-eslint/no-unused-vars

src/components/AuthButton.tsx
  Line 1:10:   'Avatar' is defined but never used                                                                                  @typescript-eslint/no-unused-vars
  Line 1:18:   'Box' is defined but never used                                                                                     @typescript-eslint/no-unused-vars
  Line 1:119:  'IconButton' is defined but never used                                                                              @typescript-eslint/no-unused-vars
  Line 1:131:  'List' is defined but never used                                                                                    @typescript-eslint/no-unused-vars
  Line 1:137:  'ListItem' is defined but never used                                                                                @typescript-eslint/no-unused-vars
  Line 1:147:  'ListItemAvatar' is defined but never used                                                                          @typescript-eslint/no-unused-vars
  Line 2:10:   'grey' is defined but never used                                                                                    @typescript-eslint/no-unused-vars
  Line 3:24:   'CloseOutlined' is defined but never used                                                                           @typescript-eslint/no-unused-vars
  Line 3:39:   'PortraitOutlined' is defined but never used                                                                        @typescript-eslint/no-unused-vars
  Line 31:42:  React Hook React.useEffect has a missing dependency: 'checkAuth'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

src/components/MainFrame/Bottom/Bottom.tsx
  Line 4:8:  'EpisodeListing' is defined but never used  @typescript-eslint/no-unused-vars

src/components/MainFrame/DownloadManager/DownloadManager.tsx
  Line 2:28:  'ProgressData' is defined but never used                                                                                 @typescript-eslint/no-unused-vars
  Line 33:6:  React Hook React.useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array        react-hooks/exhaustive-deps
  Line 41:6:  React Hook React.useEffect has a missing dependency: 'messageHandler'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

src/components/MainFrame/DownloadSelector/DownloadSelector.tsx
  Line 2:10:   'Backdrop' is defined but never used                                                                                                                                @typescript-eslint/no-unused-vars
  Line 2:33:   'Checkbox' is defined but never used                                                                                                                                @typescript-eslint/no-unused-vars
  Line 2:43:   'Chip' is defined but never used                                                                                                                                    @typescript-eslint/no-unused-vars
  Line 2:49:   'FormControl' is defined but never used                                                                                                                             @typescript-eslint/no-unused-vars
  Line 2:62:   'FormControlLabel' is defined but never used                                                                                                                        @typescript-eslint/no-unused-vars
  Line 2:80:   'IconButton' is defined but never used                                                                                                                              @typescript-eslint/no-unused-vars
  Line 2:92:   'InputLabel' is defined but never used                                                                                                                              @typescript-eslint/no-unused-vars
  Line 2:104:  'MenuItem' is defined but never used                                                                                                                                @typescript-eslint/no-unused-vars
  Line 2:114:  'OutlinedInput' is defined but never used                                                                                                                           @typescript-eslint/no-unused-vars
  Line 2:129:  'Select' is defined but never used                                                                                                                                  @typescript-eslint/no-unused-vars
  Line 36:6:   React Hook React.useEffect has missing dependencies: 'dispatch', 'messageHandler', and 'store.downloadOptions'. Either include them or remove the dependency array  react-hooks/exhaustive-deps

src/components/MainFrame/Listing/EpisodeListing.tsx
  Line 1:10:   'Accordion' is defined but never used                                                                                             @typescript-eslint/no-unused-vars
  Line 1:21:   'AccordionSummary' is defined but never used                                                                                      @typescript-eslint/no-unused-vars
  Line 1:39:   'AccordionDetails' is defined but never used                                                                                      @typescript-eslint/no-unused-vars
  Line 1:90:   'Backdrop' is defined but never used                                                                                              @typescript-eslint/no-unused-vars
  Line 1:109:  'Container' is defined but never used                                                                                             @typescript-eslint/no-unused-vars
  Line 2:10:   'ExpandMore' is defined but never used                                                                                            @typescript-eslint/no-unused-vars
  Line 5:10:   'Episode' is defined but never used                                                                                               @typescript-eslint/no-unused-vars
  Line 30:6:   React Hook React.useEffect has a missing dependency: 'store.downloadOptions.e'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  Line 87:15:  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images                         jsx-a11y/alt-text

src/components/MainFrame/Progress/Progress.tsx
  Line 1:10:   'Close' is defined but never used                                                                          @typescript-eslint/no-unused-vars
  Line 4:10:   'messageChannelContext' is defined but never used                                                          @typescript-eslint/no-unused-vars
  Line 13:5:   img elements must have an alt prop, either with meaningful text, or an empty string for decorative images  jsx-a11y/alt-text
  Line 92:21:  Expected '!==' and instead saw '!='                                                                        eqeqeq

src/components/MainFrame/SearchBox/SearchBox.tsx
  Line 42:6:   React Hook React.useEffect has a missing dependency: 'messageHandler'. Either include it or remove the dependency array  react-hooks/exhaustive-deps
  Line 63:23:  img elements must have an alt prop, either with meaningful text, or an empty string for decorative images                jsx-a11y/alt-text

src/components/reusable/ContextMenu.tsx
  Line 1:10:  'StyledOptions' is defined but never used                                                                       @typescript-eslint/no-unused-vars
  Line 2:23:  'Card' is defined but never used                                                                                @typescript-eslint/no-unused-vars
  Line 2:44:  'T
ypography' is defined but never used                                                                          @typescript-eslint/no-unused-vars
  Line 45:6:  React Hook React.useEffect has a missing dependency: 'props'. Either include it or remove the dependency array  react-hooks/exhaustive-deps

src/components/reusable/MultiSelect.tsx
  Line 2:10:   'Box' is defined but never used            @typescript-eslint/no-unused-vars
  Line 2:15:   'Chip' is defined but never used           @typescript-eslint/no-unused-vars
  Line 60:10:  Unexpected whitespace before property map  no-whitespace-before-property

src/provider/ErrorHandler.tsx
  Line 1:10:  'Backdrop' is defined but never used  @typescript-eslint/no-unused-vars

src/provider/MessageChannel.tsx
  Line 7:10:  'Backdrop' is defined but never used                                                                                                   @typescript-eslint/no-unused-vars
  Line 7:20:  'Typography' is defined but never used                                                                                                 @typescript-eslint/no-unused-vars
  Line 54:6:  React Hook React.useEffect has missing dependencies: 'dispatch' and 'ipcRenderer'. Either include them or remove the dependency array  react-hooks/exhaustive-deps
  Line 68:6:  React Hook React.useEffect has a missing dependency: 'randomEventHandler'. Either include it or remove the dependency array            react-hooks/exhaustive-deps

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

File sizes after gzip:

  117.41 kB  build/static/js/main.74e1e093.js

  226 B      build/static/css/main.17226367.css

The project was built assuming it is hosted at /.

You can control this with the homepage field in your package.json.

The build folder is ready to be deployed.
You may serve it with a static server:

  npm install -g serve

  serve -s build

Find out more about deployment here:

  https://cra.link/deployment

✓
Copying files... ✓
Installing dependencies... npm

WARN
 deprecated @types/json5@2.2.0: This is a stub types definition. json5 provides its own type definitions, so you do not need this installed.

npm
 WARN deprecated har-validator@5.1.5: this library is no longer supported

npm

WARN

deprecated
 uuid@3.4.0: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.

npm

WARN

deprecated
 request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142

added 1099 packages, and audited 1100 packages in 17s

151 packages are looking for funding
  run `npm fund` for details

found 0 vulnerabilities

✓

> multi-downloader-nx@3.0.0 build-macos-gui
> cd lib && node modules/build macos64 true

✔ Checking your system
✔ Resolving Forge Config
We need to package your application before we can make it
✔ Preparing to Package Application for arch: x64
✔ Preparing native dependencies
✔ Packaging Application
Making for the following targets: zip
✔ Making for target: zip - On platform: darwin - For arch: x64

7-Zip [64] 17.04 : Copyright (c) 1999-2021 Igor Pavlov : 2017-08-28
p7zip Version 17.04 (locale=utf8,Utf16=on,HugeFiles=on,64 bits,8 CPUs x64)

Scanning the drive:
1 folder, 1 file, 92994367 bytes (89 MiB)

Creating archive: ../../../.././_builds/multi-downloader-nx-macos64-gui.7z

Items to compress: 2

Files read from disk: 1
Archive size: 89947132 bytes (86 MiB)
Everything is Ok
izu-co commented 2 years ago

Can you try to build and then running npx electron-forge start in the lib folder? Maybe I can get more information there, because I have currently no idea what the problem could be.

XxUnkn0wnxX commented 2 years ago

still crashing the same way. Screen Shot 2022-02-20 at 4 28 00 am

Video https://user-images.githubusercontent.com/2242880/154812066-d026e7ec-2473-4893-9901-5852f39aef92.mp4

izu-co commented 2 years ago

Do you know if other electron apps work on your machine? You can try by running npx create-electron-app@latest my-app and them npm run start in the directory.

I think that this will work. The problem is I can't even find something online about the error you are facing, and I have no clue why it should only crash on mac...

izu-co commented 2 years ago

I got out my old Mac and found the issue for the crash. Apparently the response from the popup is -1 and the app is closed by my code. Why its -1 tho no idea.

I make a new release with all the builds shortly